Disable the Chrome search engine selector by default #2768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In recent versions of Chrome, a search engine selection modal is shown when first opening the browser, which causes specs to fail with errors like this:
Selenium::WebDriver::Error::UnknownError:
unknown error: failed to close window in 20 seconds
(Session info: chrome=128.0.6613.36)
Presumably this is because the spec is trying to interact with the browser but can't get past the selection screen.
This seems to be a common issue:
- https://stackoverflow.com/questions/78831994/how-to-skip-choose-search-engine-with-capybara-selenium-chrome
- https://www.reddit.com/r/learnpython/comments/1eoapcb/selenium_dosent_find_google_search_engine_option/
Adding this option appears to fix it, but I've only tested by defining my own driver locally with this argument - not sure how I'd write a spec for this driver definition?
Also I'm not sure if this option is defined for older versions of Chrome (or is it chromedriver?) - would this result in errors when using a version where this option isn't supported?
|
I confirm this is a problem specifically on MacOS. It breaks headless tests. On Linux the latest Chrome doesn't show this nag screen. But it's safe to add this option on all platforms. |
Interesting - If it's not there yet on Linux, then I guess it's coming - seems like it's a legal requirement that's been imposed on them by the EU so I'd expect it to eventually be on all platforms: https://www.google.com/chrome/choicescreen/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent versions of Chrome, a search engine selection modal is shown when first opening the browser, which causes specs to fail with errors like this:
Presumably this is because the spec is trying to interact with the browser but can't get past the selection screen.
This seems to be a common issue:
Adding this option appears to fix it, but I've only tested by defining my own driver locally with this argument - not sure how I'd write a spec for this driver definition?
Also I'm not sure if this option is defined for older versions of Chrome (or is it chromedriver?) - would this result in errors when using a version where this option isn't supported?